GH-96572: fix use after free in trace refs build mode#96618
Merged
Conversation
kumaraditya303
added
release-blocker
type-crash
pablogsal
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit d622e46 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
gvanrossum
approved these changes
Sep 6, 2022
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Amazing. Needs a backport to unblock the release, right?
Contributor
|
Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-96621 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 6, 2022
miss-islington
added a commit
that referenced
this pull request
Sep 6, 2022
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--with-trace-refsrequires objects to be explicitly removed from the global list before deallocation but ceval overrides thePy_DECREFfor speed and thus skipped this, hence we avoid this optimization in--with-trace-refsbuild mode.This optimization was introduced in 2f233fc by @gvanrossum.
Automerge-Triggered-By: GH:gvanrossum