Contextual type of methods only in noImplicitAny or JS #50542
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot run dt |
|
Heya @sandersn, I've started to run the diff-based user code test suite on this PR at 04c2fbd. You can monitor the build here. Update: The results are in! |
|
@typescript-bot test this |
sandersn
changed the title
|
User tests show a difference only in webpack, which uses checkJS -- there are two new errors where a parameter now inherits the base type but assumes a derived type. And there are many removed noImplicitAny errors. The RWC diff is empty. I hope that means there are no diffs. But I don't know how many RWC projects have noImplicitAny turned on. |
Andarist
reviewed
Aug 31, 2022
| @@ -9134,6 +9134,26 @@ namespace ts { | |||
| if (type) { | |||
| return addOptionality(type, /*isProperty*/ false, isOptional); | |||
| } | |||
| if (isMethodDeclaration(func) && isClassLike(func.parent) | |||
| && (noImplicitAny || isInJSFile(func.parent))) { // TODO: Might want to fiddle with restrictions here | |||
There was a problem hiding this comment.
out of curiosity - what's the reasoning to only apply this logic with noImplicitAny (and in JS files)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #23911, maybe