Skip to content

gh-93973: Add all_errors to asyncio.create_connection #93974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 5, 2022
Merged

gh-93973: Add all_errors to asyncio.create_connection #93974

merged 4 commits into from
Sep 5, 2022

Conversation

pamelafox
Copy link
Contributor

Adds all_errors to asyncio.create_connection, related documentation, and tests. See #93973 for background.

@pamelafox pamelafox requested review from 1st1 and asvetlov as code owners June 17, 2022 23:45
arhadthedev
arhadthedev reviewed Jun 18, 2022
View reviewed changes
@pamelafox @arhadthedev
Update Doc/library/asyncio-eventloop.rst
9722a8b 
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
gvanrossum
gvanrossum approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @kumaraditya303 do you agree?

kumaraditya303
kumaraditya303 approved these changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvanrossum gvanrossum merged commit a0ad63e into python:main Sep 5, 2022
@gvanrossum
Copy link
Member

Thanks @pamelafox !

@kumaraditya303 kumaraditya303 mentioned this pull request Sep 5, 2022
Closed
@kumaraditya303 kumaraditya303 mentioned this pull request Oct 4, 2022
Merged
@bdraco bdraco mentioned this pull request Aug 7, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pamelafox @gvanrossum @arhadthedev @kumaraditya303 @bedevere-bot