Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): initialCache: false cache not deleted #7265

Closed
wants to merge 18 commits into from

Conversation

516310460
Copy link
Contributor

@516310460 516310460 commented Sep 6, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Sep 6, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 10e4d87
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63267ec9caea2800099e73d9

@516310460
Copy link
Contributor Author

516310460 commented Sep 6, 2022

#7251

@516310460
Copy link
Contributor Author

516310460 commented Sep 6, 2022

Solve the problem that cache data is not deleted when initialCache is false, and there is a large amount of invalid data, which will affect performance. Data should be deleted when onUnmounted to reduce stack and improve performance

@516310460 516310460 changed the title Fix initialCache: false fix(nuxt): initialCache: false cache not deleted Sep 7, 2022
@pi0 pi0 force-pushed the main branch 2 times, most recently from 247e18b to c98e5c7 Compare Sep 14, 2022
@pi0
Copy link
Member

pi0 commented Nov 10, 2022

Hi, @516310460 sorry took long to check on this. The initial cache is disabled and removed (#8885).

Releasing data from memory is a good idea. Both from _asyncData and payload.data without cache. At this point, it might introduce unwanted regressions and we are close to the 3.0.0 release.

I have created #8894 to not forget about this enhancement and will ping you after v3 release if interested to help on it.

@pi0 pi0 closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants