Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-96291: fix generating global objects on windows #96394

Merged
merged 1 commit into from Aug 30, 2022
Merged

GH-96291: fix generating global objects on windows #96394

merged 1 commit into from Aug 30, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Aug 29, 2022 •
edited

@kumaraditya303 kumaraditya303 requested a review from a team as a code owner Aug 29, 2022
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Aug 29, 2022

I have verified this on Windows and it works.

@kumaraditya303 kumaraditya303 mentioned this pull request Aug 29, 2022
Closed
ericsnowcurrently
ericsnowcurrently reviewed Aug 29, 2022
View changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

That seems right to me, but I'm not super familiar with the Windows tooling.

zooba
zooba approved these changes Aug 30, 2022
View changes
@zooba zooba merged commit 13c309f into python:main Aug 30, 2022
12 checks passed
@kumaraditya303 kumaraditya303 deleted the global-objs-regen branch Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently

@zooba zooba

Assignees

@zooba zooba

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global strings do not regen on Windows
4 participants
@kumaraditya303 @ericsnowcurrently @zooba @bedevere-bot