Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95853: Improve WASM build script (GH-96389) #96389

Merged
merged 3 commits into from Aug 30, 2022
Merged

gh-95853: Improve WASM build script (GH-96389) #96389

merged 3 commits into from Aug 30, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Aug 29, 2022 •
edited by bedevere-bot

  • pre-build Emscripten ports and system libraries
  • check for broken EMSDK versions
  • use EMSDK's node for wasm32-emscripten
  • warn when PKG_CONFIG_PATH is set
  • add support level information

@tiran
pythongh-95853: Improve WASM build script
292fca0 
- pre-build Emscripten ports and system libraries
- check for broken EMSDK versions
- use EMSDK's node for wasm32-emscripten
- warn when PKG_CONFIG_PATH is set
- add support level information
@tiran tiran requested a review from brettcannon Aug 29, 2022
@tiran tiran mentioned this pull request Aug 29, 2022
Closed
rchiodo
rchiodo reviewed Aug 29, 2022
View changes
Copy link

@rchiodo rchiodo left a comment

Thanks for this

brettcannon
brettcannon approved these changes Aug 29, 2022
View changes
Tools/wasm/wasm_build.py Outdated Show resolved Hide resolved
Tools/wasm/wasm_build.py Show resolved Hide resolved
Tools/wasm/wasm_build.py Outdated Show resolved Hide resolved
Tools/wasm/wasm_build.py Outdated Show resolved Hide resolved
Tools/wasm/wasm_build.py Outdated Show resolved Hide resolved
Tools/wasm/wasm_build.py Outdated Show resolved Hide resolved
Tools/wasm/wasm_build.py Outdated Show resolved Hide resolved
Tools/wasm/wasm_build.py Outdated Show resolved Hide resolved
Tools/wasm/wasm_build.py Outdated Show resolved Hide resolved
Tools/wasm/wasm_build.py Show resolved Hide resolved
tiran and others added 2 commits Aug 30, 2022
@tiran @brettcannon
Mind the full stop
4a14001 
Co-authored-by: Brett Cannon <brett@python.org>
@tiran
Rename func to parse_emconfig, comment, black
f4be163
@tiran tiran changed the title gh-95853: Improve WASM build script gh-95853: Improve WASM build script (GH-96389) Aug 30, 2022
@tiran tiran merged commit 2eb9008 into python:main Aug 30, 2022
14 checks passed
@tiran tiran deleted the wasm_build-ports branch Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo

@brettcannon brettcannon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tiran @brettcannon @rchiodo @bedevere-bot