Remove dead code#96521
Closed
matthiasgoergens wants to merge 1 commit into
Closed
Conversation
This code has been disabled since at least 2002, ie as far as our git history goes. I guess it's fair to say that when no one has neither used nor even tested this code in 20 years, it's safer to remove it. Also, right now this code contributes to warning spam in clang.
Member
|
This is vendorised code. As such, I think it would be better to leave it as is to avoid unnecessary divergence from the upstream code. If you feel strongly enough about this, maybe see if you can convince the |
Contributor
Author
|
Thanks, I didn't know that it was directly taken from upstream. I was just fixing compiler warnings. I might see if libexpaz wants the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code has been disabled since at least 2002, ie as far as our git
history goes. I guess it's fair to say that when no one has neither used nor
even tested this code in 20 years, it's safer to remove it.
Also, right now this code contributes to warning spam in clang.