Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that env vars are at least somewhat case insensitive on Windows #19627

Open
1 task done
jsoref opened this issue Aug 9, 2022 · 1 comment
Open
1 task done
Labels
actions content waiting for review

Comments

@jsoref
Copy link
Contributor

jsoref commented Aug 9, 2022

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable

What part(s) of the article would you like to see updated?

The names of environment variables are case-sensitive, and you can include punctuation.

This is true on Linux (and macOS).

However, my understanding is that this is at least partially untrue on Windows:
https://github.com/actions/runner/blob/cb19da9638790019f6e7be193cd4282311992b12/src/Runner.Worker/ActionCommandManager.cs#L158-L162

I say partially, because I haven't extensively tested the code paths.

Additional information

No response

@jsoref jsoref added the content label Aug 9, 2022
@github-actions github-actions bot added the triage label Aug 9, 2022
@cmwilson21 cmwilson21 added waiting for review actions and removed triage labels Aug 10, 2022
@cmwilson21
Copy link
Collaborator

cmwilson21 commented Aug 10, 2022

👋 @jsoref Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions content waiting for review
Projects
None yet
Development

No branches or pull requests

2 participants