C#: Narrow collection like types in model generation.#10158
Merged
michaelnebel merged 8 commits intoAug 30, 2022
Conversation
michaelnebel
force-pushed
the
csharp/narrowcollectiontypes
branch
2 times, most recently
from
0ef47b4 to
b17d9e3
Compare
Contributor
Click to show differences in coveragecsharpGenerated file changes for csharp
- System,"``System.*``, ``System``",4,11809,43,7
+ System,"``System.*``, ``System``",695,12081,65,7
- Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,554,138,
+ Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",14,555,138,
- Totals,,4,12370,375,7
+ Totals,,709,12643,397,7
- Microsoft.Extensions.Configuration,,,83,,,,,,,,,,,,80,3
+ Microsoft.Extensions.Configuration,,4,83,,,,,,,,,,4,,80,3
- Microsoft.Extensions.FileProviders,,,15,,,,,,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,1,16,,,,,,,,,,1,,16,
- Microsoft.Extensions.Primitives,,,63,,,,,,,,,,,,63,
+ Microsoft.Extensions.Primitives,,2,63,,,,,,,,,,2,,63,
- Microsoft.NET.Build.Tasks,,,1,,,,,,,,,,,,1,
+ Microsoft.NET.Build.Tasks,,4,1,,,,,,,,,,4,,1,
- Microsoft.NETCore.Platforms.BuildTasks,,,4,,,,,,,,,,,,4,
+ Microsoft.NETCore.Platforms.BuildTasks,,3,4,,,,,,,,,,3,,4,
- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,65,695,12081,,8,8,9,,4,,33,3,692,3,10139,1942 |
Contributor
Click to show differences in coveragecsharpGenerated file changes for csharp
- System,"``System.*``, ``System``",4,11809,43,7
+ System,"``System.*``, ``System``",4,12081,65,7
- Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,554,138,
+ Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,555,138,
- Totals,,4,12370,375,7
+ Totals,,4,12643,397,7
- Microsoft.Extensions.FileProviders,,,15,,,,,,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,16,
- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,65,4,12081,,8,8,9,,4,,33,3,1,3,10139,1942 |
michaelnebel
force-pushed
the
csharp/narrowcollectiontypes
branch
from
50ed1ea to
f4835e3
Compare
Contributor
Click to show differences in coveragecsharpGenerated file changes for csharp
- System,"``System.*``, ``System``",4,11809,43,7
+ System,"``System.*``, ``System``",4,12081,65,7
- Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,554,138,
+ Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,555,138,
- Totals,,4,12370,375,7
+ Totals,,4,12643,397,7
- Microsoft.Extensions.FileProviders,,,15,,,,,,,,,,,,15,
+ Microsoft.Extensions.FileProviders,,,16,,,,,,,,,,,,16,
- System,43,4,11809,,1,1,1,,4,,33,3,1,3,9867,1942
+ System,65,4,12081,,8,8,9,,4,,33,3,1,3,10139,1942 |
michaelnebel
added
the
no-change-note-required
Contributor
Author
DCA did not show any improvements or regressions (but shows that there is a bunch of source models that will no longer be produced (as expected)). |
aschackmull
approved these changes
Aug 29, 2022
hvitved
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to
To see the impact of the change above, models were regenerated based on main and committed as a part of this PR, such that we can pinpoint the exact diff in model generation that this PR produces.
This revealed some interesting things
Will try to run DCA to check if the exclusion of collection like types narrows the search space in way that is measurable in terms of performance.