refactor: prefer f-strings to other format/concatentation styles #8474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Aug 3, 2022
Have you:
- Checked for
%? Just to be sure - Thought of any CI check to prevent this from happening again?
srittau
approved these changes
Aug 3, 2022
I've been toying around with breaking out this functionality and parts of flake8-pyi to be more generic so that I can more easily detect deprecated typing imports for target python version, f-strings if available, contextlib if available, etc. across open and closed source projects, but I'm concerned that it'll simply lead to more plugin fragmentation than a way to solve the core problem. If you have a suggestion or approach you'd like to see, I'm happy to work on it |
I don't think we really need a CI check for this. It's fine to do cleanups every now and then, but we don't have very many |
kkirsche
added a commit
to kkirsche/typeshed
that referenced
this issue
Aug 3, 2022
* master: Remove `Enum.__hash__`, improve `Enum.__reduce_ex__` (python#8477) refactor: prefer f-strings to other format/concatentation styles (python#8474) Remove redundant `__str__` methods (python#8475) Add some missing stubs in datetimerange (python#8470) tkinter: get rid of unnecessary Incomplete (python#8471) Improve urllib3.util.url annotations (python#8460) Fix `complex` constructor (python#8473) [pre-commit.ci] pre-commit autoupdate (python#8461) Use typeshed.Incomplete and object instead of Any in tkinter stubs (python#8458)
kkirsche
added a commit
to kkirsche/typeshed
that referenced
this issue
Aug 4, 2022
* master: Add `urllib3.contrib.socks`; improve `urllib3.connectionpool` (python#8457) Improve `multiprocessing.context` module (python#8466) Always return `True` from `xml.dom.minidom.Node.__bool__` (python#8480) Adds missing `__dir__` definitions (python#8479) Various pyvmomi improvements (python#8469) Bump pytype version. (python#8478) Remove `Enum.__hash__`, improve `Enum.__reduce_ex__` (python#8477) refactor: prefer f-strings to other format/concatentation styles (python#8474) Remove redundant `__str__` methods (python#8475) Add some missing stubs in datetimerange (python#8470) tkinter: get rid of unnecessary Incomplete (python#8471) Improve urllib3.util.url annotations (python#8460) Fix `complex` constructor (python#8473) [pre-commit.ci] pre-commit autoupdate (python#8461) Use typeshed.Incomplete and object instead of Any in tkinter stubs (python#8458) `io.IOBase`: correct metaclass (python#8468)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Use f-strings for concatenating strings instead of
'+'or.formatPython added f-strings in version 3.6, with PEP 498. F-strings are a flexible and powerful way to concatenate strings. They make the code shorter and more readable, since the code now looks more like the output. In addition, they also come with performance benefits as they reduce the number of times the string must be processed, resulting in faster string processing.
This aligns with the desire to ensure that scripts and tests should support currently supported versions of Python outlined here