Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: support cidr blocks egress control with --allow-net #9816

Open
alexanderGalushka opened this issue Mar 17, 2021 · 3 comments
Open

feature: support cidr blocks egress control with --allow-net #9816

alexanderGalushka opened this issue Mar 17, 2021 · 3 comments
Labels
good first issue permissions suggestion

Comments

@alexanderGalushka
Copy link

@alexanderGalushka alexanderGalushka commented Mar 17, 2021

currently --allow-net supports only IPs and domains, unfortunately it doesn't support cidr blocks yet

e.g.

deno run --allow-net=xyz.com,abc.com,10.0.0.11/24
@kitsonk kitsonk added permissions suggestion labels Mar 17, 2021
@lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Mar 18, 2021 •
edited

CIDR blocks would require us to resolve hostnames to IP addresses before matching against the net allow list. Possible, but not easy to implement.

@sh7dm sh7dm mentioned this issue Jul 24, 2021
Closed
@bnoordhuis bnoordhuis added the good first issue label Dec 15, 2021
@bnoordhuis
Copy link
Contributor

@bnoordhuis bnoordhuis commented Dec 15, 2021

#11509 unfortunately stalled but that means this feature is up for grabs again.

@nebarf
Copy link

@nebarf nebarf commented Feb 25, 2022

@bnoordhuis I can grab the issue if it sounds good to you. Will take me some time to familiarize with the codebase

@nebarf nebarf mentioned this issue Feb 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue permissions suggestion
Projects
None yet
Milestone
No milestone
5 participants
@bnoordhuis @kitsonk @nebarf @lucacasonato @alexanderGalushka