Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45608: Document missing sqlite3 DB-API attributes and methods #29219

Merged
merged 7 commits into from Oct 28, 2021
Merged

bpo-45608: Document missing sqlite3 DB-API attributes and methods #29219

merged 7 commits into from Oct 28, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Oct 25, 2021 •
edited

Document DB-API required attributes and methods:

  • sqlite3.apilevel
  • sqlite3.paramstyle
  • sqlite3.threadsafety
  • sqlite3.Cursor.setinputsizes()
  • sqlite3.Cursor.setoutputsize()

https://bugs.python.org/issue45608

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 25, 2021
@erlend-aasland erlend-aasland requested a review from malemburg Oct 25, 2021
@erlend-aasland erlend-aasland changed the title bpo-45608: Document missing sqlite3 DB-API attributes bpo-45608: Document missing sqlite3 DB-API attributes and methods Oct 25, 2021
@erlend-aasland erlend-aasland requested a review from pfmoore Oct 25, 2021
pfmoore
pfmoore approved these changes Oct 26, 2021
View changes
Copy link
Member

@pfmoore pfmoore left a comment

Approved with just one minor nitpick.

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Oct 26, 2021 •
edited

PTAL, @pfmoore. Thanks for reviewing!

I also pushed a small wording improvement in b087d3a

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Oct 26, 2021

Thanks, Paul! @malemburg, does this look good to you?

@erlend-aasland erlend-aasland mentioned this pull request Oct 26, 2021
Merged
@erlend-aasland erlend-aasland requested a review from willingc Oct 26, 2021
@ambv ambv merged commit 88d8a1a into python:main Oct 28, 2021
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 28, 2021

Thanks @erlend-aasland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 28, 2021
@erlend-aasland @miss-islington
bpo-45608: Document missing sqlite3 DB-API attributes and methods (p…
13db640 
…ythonGH-29219)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 28, 2021

GH-29281 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 28, 2021
@erlend-aasland @miss-islington
bpo-45608: Document missing sqlite3 DB-API attributes and methods (p…
9787ff2 
…ythonGH-29219)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 28, 2021

GH-29282 is a backport of this pull request to the 3.9 branch.

@erlend-aasland erlend-aasland deleted the sqlite-doc-dbapi branch Oct 28, 2021
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Oct 28, 2021

Thanks, Łukasz!

ambv pushed a commit that referenced this issue Oct 28, 2021
@miss-islington @erlend-aasland
bpo-45608: Document missing sqlite3 DB-API attributes and methods (G…
1d88b2b 
…H-29219) (GH-29281)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
ambv pushed a commit that referenced this issue Oct 28, 2021
@miss-islington @erlend-aasland
bpo-45608: Document missing sqlite3 DB-API attributes and methods (G…
020aa06 
…H-29219) (GH-29282)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jul 27, 2022
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfmoore pfmoore

@berkerpeksag berkerpeksag

@malemburg malemburg

@willingc willingc

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@erlend-aasland @miss-islington @bedevere-bot @pfmoore @ambv @the-knights-who-say-ni