C#: Handle dotnet exec csc.dll and the likes in the Lua tracer#9989
Merged
Conversation
hvitved
force-pushed
the
csharp/lua-tracer-improvements2
branch
2 times, most recently
from
a64866a to
51c4930
Compare
hvitved
force-pushed
the
csharp/lua-tracer-improvements2
branch
from
51c4930 to
c5d3b1f
Compare
michaelnebel
previously approved these changes
Aug 10, 2022
michaelnebel
left a comment
michaelnebel
left a comment
Contributor
There was a problem hiding this comment.
Looks plausible to me!
criemen
previously approved these changes
Aug 10, 2022
criemen
left a comment
criemen
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me as well, thanks!
hvitved
force-pushed
the
csharp/lua-tracer-improvements2
branch
from
c5d3b1f to
2bb9e48
Compare
Contributor
Author
|
Rebased onto latest |
michaelnebel
approved these changes
Aug 10, 2022
michaelnebel
left a comment
michaelnebel
left a comment
Contributor
There was a problem hiding this comment.
Looks plausible to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves logic for handling
dotnet exec csc.dlland friends from the extractor into the new Lua tracer spec. The benefit of doing so is that we can avoid unnecessary process creations, and logically doing compiler matching belongs to the tracer spec, and not the extractor.Note that the logic has not yet been removed from the extractor; we will do so once the legacy tracer is retired.
Thanks to @criemen for helping out.