Add epoch query API to authorityAPI #3725
Merged
+173
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwill
approved these changes
Aug 3, 2022
| .tap_err(|err| { | ||
| self.report_client_error(err); | ||
| })?; |
There was a problem hiding this comment.
Generally this is not how logging should be handled, the macro invocation should be inlined here in order to properly report line numbers, etc.
asonnino
approved these changes
Aug 3, 2022
crates/sui-core/src/authority_active/gossip/configurable_batch_action_client.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add an API to AuthorityAPI that can request authenticated epoch data structure.
Cannot add the proper verify function in SafeClient yet, because that depends on hooking up the SafeClient and the state store in order to fetch the committee.