Skip to content

revert change to pass location by value#95360

Closed
iritkatriel wants to merge 1 commit into
python:mainfrom
iritkatriel:loc_by_ref
Closed

revert change to pass location by value#95360
iritkatriel wants to merge 1 commit into
python:mainfrom
iritkatriel:loc_by_ref

Conversation

@iritkatriel
Copy link
Copy Markdown
Member

No description provided.

@iritkatriel iritkatriel requested a review from markshannon as a code owner July 28, 2022 08:36
@iritkatriel iritkatriel marked this pull request as draft July 28, 2022 08:36
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 28, 2022
@bedevere-bot
Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit d2fc454 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 28, 2022
@markshannon
Copy link
Copy Markdown
Member

This may well make the tests pass. It probably will.
But that's not the issue. All that will happen is that some other small change will cause the same failure in a week or two.

@iritkatriel iritkatriel closed this Aug 1, 2022
@iritkatriel iritkatriel deleted the loc_by_ref branch September 29, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants