Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing decref in error case of ExceptionGroup split() #95369

Closed
iritkatriel opened this issue Jul 28, 2022 · 0 comments
Closed

missing decref in error case of ExceptionGroup split() #95369

iritkatriel opened this issue Jul 28, 2022 · 0 comments
Labels
3.11 3.12 interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Jul 28, 2022

Noticed in the code:

            if (PyList_Append(match_list, rec_result.match) < 0) {
                Py_DECREF(rec_result.match);
                goto done;
            }

We are missing a Py_XDECREF(rec_result.rest); before the goto done.
@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.11 3.12 labels Jul 28, 2022
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jul 28, 2022
@iritkatriel
pythongh-95369: add missing decref in error case of exception group's…
cc0471d 
… split
@bedevere-bot bedevere-bot mentioned this issue Jul 28, 2022
Merged
iritkatriel added a commit that referenced this issue Jul 28, 2022
@iritkatriel
gh-95369: add missing decref in error case of exception group's split (…
bceb197 
…GH-95370)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 28, 2022
@iritkatriel @miss-islington
pythongh-95369: add missing decref in error case of exception group's…
8520969 
… split (pythonGH-95370)

(cherry picked from commit bceb197)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Jul 28, 2022
Merged
miss-islington added a commit that referenced this issue Jul 28, 2022
@miss-islington @iritkatriel
gh-95369: add missing decref in error case of exception group's split (…
6934726 
…GH-95370)

(cherry picked from commit bceb197)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 3.12 interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iritkatriel