I think it would be better to not set the signal handler if the task is missing the uncancel method. There's already a threading.main_thread() check

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I'm not landing this into beta 5 because we should address Yuri's comments, but this will block RC1 and I don't want to steal one day for a release that's only going to be out for a week.

This means that people should manually test this or use nightly builds to ensure it works once is landed.

Changed it to raise CancelledError, I have made the requested changes; please review again

Thanks for making the requested changes!

@1st1: please review the changes made to this pull request.

Kumar all this needs is two nits to be fixed.

On it.

Looking at this comment from @1st1:

If the uncancel() method doesn't exist we should, IMO, just propagate the cancelled error as is. At least I don't see any reasons not to (and for emulating uncancel()) and there's no comment explaining the current approach of the PR.

We implemented that, so this should be okay. It seems clear enough from the code what is happening now so I don't believe we need another comment.

Oh, what's wrong with the Windows test? It fails with a byteswarning. Do we need to merge main?

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

GH-95387 is a backport of this pull request to the 3.11 branch.