-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Open
Labels
PythonacknowledgedGitHub staff acknowledges this issueGitHub staff acknowledges this issuefalse-positive
Description
Description of the false positive
Using multiple base classes from sklearn.base together, e.g.,
from sklearn.base import BaseEstimator, ClusterMixin
class Clustering(ClusterMixin, BaseEstimator):
...LGTM identifies following error: Base classes have conflicting values for attribute '_more_tags': Function _more_tags and Function _more_tags.
I think that this is a false positive, because both functions _more_tags are used via the inspect.getmro function
def _get_tags(self):
collected_tags = {}
for base_class in reversed(inspect.getmro(self.__class__)):
if hasattr(base_class, "_more_tags"):
# need the if because mixins might not have _more_tags
# but might do redundant work in estimators
# (i.e. calling more tags on BaseEstimator multiple times)
more_tags = base_class._more_tags(self)
collected_tags.update(more_tags)
return collected_tagsCheckout the full definition
URL to the alert on the project page on LGTM.com
https://lgtm.com/projects/g/moldyn/MoSAIC/snapshot/c1df9c1a96a193a3e400986fb71b550bf0c42e2f/files/src/mosaic/clustering.py?sort=name&dir=ASC&mode=heatmap#x8e6a118dd37a8a7:1
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
PythonacknowledgedGitHub staff acknowledges this issueGitHub staff acknowledges this issuefalse-positive