Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95173: Revert commit 51ed2c56a1852cd6b09c85ba81312dc9782772ce #95176

Merged
merged 1 commit into from Jul 24, 2022
Merged

gh-95173: Revert commit 51ed2c56a1852cd6b09c85ba81312dc9782772ce #95176

merged 1 commit into from Jul 24, 2022

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 23, 2022 •
edited by bedevere-bot

Closes: #95173

@pablogsal pablogsal changed the title bpo-45530: Revert commit 51ed2c56a1852cd6b09c85ba81312dc9782772ce gh-95173: Revert commit 51ed2c56a1852cd6b09c85ba81312dc9782772ce Jul 23, 2022
@pablogsal
Copy link
Member Author

@pablogsal pablogsal commented Jul 23, 2022

I will merge this in 24h unless someone has concerns.

@rhettinger rhettinger added the 🔨 test-with-buildbots label Jul 23, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 23, 2022

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 5a3ebf3 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Jul 23, 2022
@pablogsal pablogsal merged commit 9007dec into python:main Jul 24, 2022
75 of 89 checks passed
@pablogsal pablogsal deleted the revert-45530 branch Jul 24, 2022
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 24, 2022

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 24, 2022
@pablogsal @miss-islington
pythongh-95173: Revert commit 51ed2c5 (pythonGH-95176)
588d0cb 
(cherry picked from commit 9007dec606b790c05e158e588b696f3c210c2795)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 24, 2022

GH-95220 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this issue Jul 24, 2022
@miss-islington @pablogsal
gh-95173: Revert commit 51ed2c5 (GH-95176)
88ea2b6 
(cherry picked from commit 9007dec)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweeneyde sweeneyde

@serhiy-storchaka serhiy-storchaka

@tim-one tim-one

@rhettinger rhettinger

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting tuples containing None raises TypeError in 3.11
4 participants
@pablogsal @bedevere-bot @miss-islington @rhettinger