GH-94438: Handle extended arguments and conditional pops in mark_stacks
#95110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
added
type-crash
|
See also #95113. If we go that route, this PR will need to be updated. |
|
This will probably tick some coverage boxes in #94808. |
|
I also noticed that we're not treating |
brandtbucher
changed the title
mark_stacksmark_stacks
|
Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry @brandtbucher, I had trouble checking out the |
brandtbucher
added
needs backport to 3.11
|
Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 22, 2022
…k_stacks (pythonGH-95110) (cherry picked from commit e4d3a96) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
|
GH-95154 is a backport of this pull request to the 3.11 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mark_stackshasn't handled extended arguments correctly for some time now:get_arghelper function checks forEXTENDED_ARGopcodes, but it should be checking forEXTENDED_ARG_QUICK(which is what the compiler and_PyCode_GetCodeproduce)defaultcase doesn't callget_arg, but shouldI've added some regression tests, as well as a few assertions that would have made catching and debugging this issue much easier.