Fix test_get_ciphers to work also in environments with FIPS#95084
Closed
frenzymadness wants to merge 1 commit into
Closed
Fix test_get_ciphers to work also in environments with FIPS#95084frenzymadness wants to merge 1 commit into
frenzymadness wants to merge 1 commit into
Conversation
If FIPS is enabled, cipher "AES256-GCM-SHA384" is not available but a variant of it is, like "ECDHE-ECDSA-AES256-GCM-SHA384".
|
All commit authors signed the Contributor License Agreement. |
stratakis
approved these changes
Jul 26, 2022
Contributor
stratakis
left a comment
stratakis
left a comment
There was a problem hiding this comment.
The code changes are trivial and the test passes on a FIPS enabled RHEL9 and CentOS Stream 9 machine.
Contributor
Author
|
Replaced by #95282 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If FIPS is enabled, cipher "AES256-GCM-SHA384" is not available
but a variant of it is, like "ECDHE-ECDSA-AES256-GCM-SHA384".
We have briefly discussed this with @tiran. He said that we can also remove the test but because the
get_ciphersmethod is used only in two tests in this file andtest_python_ciphersis skipped unlessPY_SSL_DEFAULT_CIPHERS == 1, I believe it's still useful.Cc @stratakis