gh-95081: Allow shallow and deep copying of memoryview object#95082
Closed
corona10 wants to merge 9 commits into
Closed
gh-95081: Allow shallow and deep copying of memoryview object#95082corona10 wants to merge 9 commits into
corona10 wants to merge 9 commits into
Conversation
corona10
added
needs backport to 3.10
Member
Author
|
Need to discuss before reviewing this PR. |
corona10
commented
Jul 21, 2022
Member
Author
There was a problem hiding this comment.
Even if property object is allowed for copy operation, property object does not allow to be pickled.
Member
Author
There was a problem hiding this comment.
>>> import pickle
>>> import copy
>>> a = property()
>>> pickle.dumps(a)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: cannot pickle 'property' object
>>> copy.copy(a)
<property object at 0x101017230>
>>> copy.deepcopy(a)
<property object at 0x101017230>
Member
Author
|
I am not sure to add backport patch even if this operation is allowed. cc @serhiy-storchaka |
corona10
changed the title
corona10
changed the title
Member
Author
|
@serhiy-storchaka gentle ping :) |
| d[types.MethodType] = _deepcopy_method | ||
|
|
||
| def _deepcopy_memoryview(x, memo, deepcopy=deepcopy): | ||
| y = memoryview(deepcopy(x.obj, memo)) |
Member
There was a problem hiding this comment.
This can fail in several ways:
- Doesn't preserver readonly state. For example, copying
memoryview(bytearray(b"hi")).toreadonly()will create an MV that's not readonly. This is fixable though. - Memoryviews created through
PyMemoryView_FromBufferorPyMemoryView_FromMemorymay not have an underlyingobj, and cannot be constructed directly from Python, so this will not copy them faithfully. I don't see a way to fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.