-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Support fields under body as well as in url for field_caps API. #86875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
Pinging @elastic/es-search (Team:Search) |
|
@pryadko I had a few questions to make sure we have all the context.
|
|
@jtibshirani |
|
This is somehow similar to #61141 , but for fields and very specific to the field_caps API. I do worry that there are possibly many other places where a similar change should be made if we go down this route. I marked it for discussion with the team. |
|
@pryadko sorry for the slow reply. I discussed with the team, and confirmed that Elasticsearch should not be throwing "414 "Request-URI Too Long". This must be coming from some other place, like a web server. Maybe it's possible to change the server configuration to allow larger requests? We also recognized how the change we made could cause inconvenience. In other places like |
|
@jtibshirani thank you for your answer. Do you have a plan to fix this? or it still continues discussion? |
|
We don't have immediate plans to change this. The motivation for removing the ability to specify We are still discussing the topic internally though, I'll post an update if anything changes. |
|
@jtibshirani thanks,
I'm looking forward to your decision. |
|
@elastic/es-clients do you have a suggestion for how to move forward? We want to avoid making a breaking change, like removing the ability to pass
|
|
We discussed offline and decided to re-add support for I don't think I have time to tackle this soon, but I am marking it as "help wanted". |
|
@jtibshirani thank you, I will try to help with this. |
|
Hi! I would love to help, you think I can give it a try? |
…uest body (elastic#88972) We previously removed support for `fields` in the request body, to ensure there was only one way to specify the parameter. We've now decided to undo the change, since it was disruptive and the request body is actually the best place to pass variable-length data like `fields`. This PR restores support for `fields` in the request body. It throws an error if the parameter is specified both in the URL and the body. Closes elastic#86875
Description
Before ES 7.x it was possible to provide a list of fields by URL or BODY request for field_caps API.
https://www.elastic.co/guide/en/elasticsearch/reference/6.8/search-field-caps.html
POST _field_caps { "fields" : ["rating"] }Starting from 7.x this feature was removed, and only one possible way it uses URI but in this case, it is possible to have an error 414 (Request-URI Too Long).
I would like to return this feature back.
The text was updated successfully, but these errors were encountered: