Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_decimal fails to build with --with-pydebug --with-lto on GCC #94847

Closed
tiran opened this issue Jul 14, 2022 · 1 comment
Closed

_decimal fails to build with --with-pydebug --with-lto on GCC #94847

tiran opened this issue Jul 14, 2022 · 1 comment
Labels
type-bug

Comments

@tiran
Copy link
Member

@tiran tiran commented Jul 14, 2022

Bug report

GH-94474 caused several buildbots with GCC to fail to compile _decimal module with --with-pydebug --with-lto option. The problem did not show up when I was testing my PR on the build bot farm. I can reproduce the issue locally with GCC 12.1.1. Build does not fail with non-debug builds. Only the combination of LTO and debug fails for me

../Modules/_decimal/libmpdec/mpdecimal.c: In function ‘exp_to_string’:
../Modules/_decimal/libmpdec/mpdecimal.c:143:1: error: inlining failed in call to ‘always_inline’ ‘mpd_word_digits’: function not considered for inlining
  143 | mpd_word_digits(mpd_uint_t word)
      | ^
@tiran tiran added the type-bug label Jul 14, 2022
@tiran
Copy link
Member Author

@tiran tiran commented Jul 14, 2022

_decimal has been broken on LTO + pydebug builds for a while. We just didn't notice because build failure was not fatal and did not cause the buildbot to break. Here is an older build run from two days ago, https://buildbot.python.org/all/#/builders/285/builds/2550

tiran added a commit to tiran/cpython that referenced this issue Jul 14, 2022
@tiran
pythongh-94847: Don't force inlining in debug builds of libmpdec
20177b4
@bedevere-bot bedevere-bot mentioned this issue Jul 14, 2022
Merged
tiran added a commit that referenced this issue Jul 18, 2022
@tiran
gh-94847: Don't force inlining in debug builds of libmpdec (GH-94848)
97b4121
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 18, 2022
@tiran @miss-islington
pythongh-94847: Don't force inlining in debug builds of libmpdec (pyt…
f8c9943 
…honGH-94848)

(cherry picked from commit 97b4121)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot mentioned this issue Jul 18, 2022
Merged
@tiran tiran closed this as completed Jul 18, 2022
tiran added a commit that referenced this issue Jul 18, 2022
@miss-islington @tiran
[3.11] gh-94847: Don't force inlining in debug builds of libmpdec (GH…
4607e88 
…-94848) (GH-94951)

Co-authored-by: Christian Heimes <christian@python.org>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this issue Jul 19, 2022
@tiran @iritkatriel
pythongh-94847: Don't force inlining in debug builds of libmpdec (pyt…
12bd2af 
…honGH-94848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tiran