Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use 'recursively' in the description of rglob, and mention globs in the os equivalences #94954

Merged
merged 2 commits into from Jul 20, 2022

Conversation

nedbat
Copy link
Member

@nedbat nedbat commented Jul 18, 2022

The r in rglob stands for "recursively", so use the word in the description. Also, glob and rglob can usefully be mentioned as the pathlib equivalent of os.walk.

Automerge-Triggered-By: GH:brettcannon

@nedbat nedbat requested a review from brettcannon as a code owner Jul 18, 2022
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 18, 2022
@nedbat nedbat added docs Documentation in the Doc dir skip news skip issue and removed docs Documentation in the Doc dir skip news labels Jul 18, 2022
Doc/library/pathlib.rst Outdated Show resolved Hide resolved
@brettcannon brettcannon added needs backport to 3.10 needs backport to 3.11 🤖 automerge PR will be merged once it's been approved and all CI passed labels Jul 20, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jul 20, 2022

Status check is done, and it's a success .

@miss-islington miss-islington merged commit 6e2fbda into python:main Jul 20, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jul 20, 2022

Thanks @nedbat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Jul 20, 2022

Sorry @nedbat, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6e2fbdab9220e20bc0e7f9e20987bb1e18532585 3.11

@miss-islington miss-islington self-assigned this Jul 20, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jul 20, 2022

GH-95071 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2022
…s in the os equivalences (pythonGH-94954)

The r in `rglob` stands for "recursively", so use the word in the description. Also, glob and rglob can usefully be mentioned as the pathlib equivalent of os.walk.

Automerge-Triggered-By: GH:brettcannon
(cherry picked from commit 6e2fbda)

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
@brettcannon
Copy link
Member

brettcannon commented Jul 20, 2022

@nedbat do you care enough to try and fix the 3.11 backport failure? If you are I can leave the 3.10 PR open for merging. Otherwise I'm also fine making this a 3.12 improvement alone.

@nedbat
Copy link
Member Author

nedbat commented Jul 20, 2022

Let's just go with 3.12. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir needs backport to 3.11 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants