Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGTM.com - false positive - unused import needed for API #9651

Open
jlaehne opened this issue Jun 22, 2022 · 2 comments
Open

LGTM.com - false positive - unused import needed for API #9651

jlaehne opened this issue Jun 22, 2022 · 2 comments
Labels
false-positive Python

Comments

@jlaehne
Copy link

@jlaehne jlaehne commented Jun 22, 2022

Description of the false positive

Unused import raised for imports that are carried out just to build the API-structure.

URL to the alert on the project page on LGTM.com
@jlaehne jlaehne changed the title LGTM.com - false positive LGTM.com - false positive - unused import needed for API Jun 22, 2022
@jlaehne jlaehne mentioned this issue Jun 22, 2022
Open
@tausbn
Copy link
Contributor

@tausbn tausbn commented Jun 22, 2022

Thank you for your report!

In this case, I'm less sure whether I would consider this a false positive. If, as you indicate, these imports are placed so as to expose a particular API on the modules that they are contained in, then perhaps it would make sense to make this explicit by including them in the __all__ list of public names. I believe this should be enough to make the alerts go away.

@tausbn tausbn added the Python label Jun 22, 2022
@jlaehne
Copy link
Author

@jlaehne jlaehne commented Jun 22, 2022

OK, I'll have a deeper look into this one. Thanks for the quick replies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-positive Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tausbn @jlaehne