Regex doesn't work properly #9562

MFaisalZaki · 2022-06-15T10:05:36Z

I am trying to recognize #pragma pack directive for MSVC. Therefore, I have wrote this simple query:

import cpp

from PreprocessorDirective directive
where directive.getHead().regexpMatch("pack*")
select directive

to capture the following two pack pragmas in this sample:

#pragma pack(push, 1)
#include "my_header.h"
#pragma pack(pop)

However, after various tries with regexpMatch and matches the query cannot capture the proper pattern even though I have tried the same pattern using RegExr and it is working as expected.

The text was updated successfully, but these errors were encountered:

hmakholm · 2022-06-15T10:37:07Z

Your regular expression should be "pack.*" -- that is, pack followed by zero or more arbitrary characters.
"pack*" would mean the that the text of the directive needs to be pac followed by zero or more copies k.

(It looks like you were trying to use filename globbing syntax rather than regular expressions).

You could also write .matches("pack%") if you prefer the more SQL-like pattern syntax that matches uses.

Finally, for general neatness, you'll probably want directive to have type PreprocessorPragma rather than PreprocessorDirective).

MFaisalZaki added the question label Jun 15, 2022

hmakholm added the C++ label Jun 15, 2022

Regex doesn't work properly #9562

Regex doesn't work properly #9562

MFaisalZaki commented Jun 15, 2022 •

edited

hmakholm commented Jun 15, 2022

Regex doesn't work properly #9562

Regex doesn't work properly #9562

Comments

MFaisalZaki commented Jun 15, 2022 • edited

hmakholm commented Jun 15, 2022

MFaisalZaki commented Jun 15, 2022 •

edited