build(bazel): remove rules_nodejs patch #46774
Open
+2
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch was added to remove an unnecessary wrapper script around nodejs binaries which prevented running esm scripts when the linker was disabled.
devversion
approved these changes
Jul 11, 2022
jessicajaniuk
added
the
comp: build & ci
jessicajaniuk
added
action: cleanup
target: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
@devversion @josephperrott @gregmagolan
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Needed a patch to use ESM scripts with the linker disabled.
What is the new behavior?
rules_nodejs has been updated and the patch is no longer needed.
Does this PR introduce a breaking change?