Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router standalone directives #46758

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Jul 8, 2022

See individual commits

atscott added 7 commits Jul 8, 2022
This commit makes the router directives standalone and refactors some of
the Router injectables to be `providedIn: 'root'` along with factory
functions for initialization.
This commit updates the Router itself to be `providedIn: 'root'` with a
factory function rather than provided in the `RouterModule`.
`entryComponents` is a feature that is not used or necessary in Angular
anymore.
The provideRoutes function of the Router returns a Provider array and should not be typed as 'any'
The BOOTSTRAP_DONE/bootstrapDone Subject is only used as part of the
`enabledBlocking` initial navigation. Rather than completing the subject
in a common bootstrap listener, this logic can be done in its own
listener as part of the `provideEnabledBlockingInitialNavigation`
function.
The PathLocationStrategy is already provided by default in the factory of LocationStrategy
@ngbot ngbot bot added this to the Backlog milestone Jul 8, 2022
@atscott atscott force-pushed the routerStandaloneDirectives branch from aa420a3 to c406e30 Compare Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants