Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): expose ControlConfig in public API #46594

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

udaysonyy
Copy link

@udaysonyy udaysonyy commented Jun 29, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • [ x ] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #46570

What is the new behavior?

We can use ControlConfig type in application

  • import { ControlConfig } from '@angular/forms';

Does this PR introduce a breaking change?

  • Yes
  • [ x ] No

Other information

@google-cla
Copy link

@google-cla google-cla bot commented Jun 29, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from dylhunn Jun 29, 2022
@udaysonyy
Copy link
Author

@udaysonyy udaysonyy commented Jun 29, 2022

I have signed Contributor License Agreement (CLA).

@dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Jun 29, 2022

@udaysonyy It looks like this needs to be formatted:

yarn ng-dev format files packages/forms/src/forms.ts

as well as have the API changes accepted:

yarn bazel run //packages/forms:forms_api.accept

Then you'll want to amend your current commit:

git add .
git commit --no-edit --amend

@dylhunn dylhunn added action: cleanup comp: forms target: patch labels Jun 29, 2022
@ngbot ngbot bot added this to the Backlog milestone Jun 29, 2022
@ngbot ngbot bot added this to the Backlog milestone Jun 29, 2022
@udaysonyy
Copy link
Author

@udaysonyy udaysonyy commented Jun 30, 2022

When I tried to run yarn bazel run //packages/forms:forms_api.accept, i am getting this error i tried my best but it's the same.

image

image

@udaysonyy
Copy link
Author

@udaysonyy udaysonyy commented Jul 1, 2022

I've tried so much but yarn is not working properly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: cleanup comp: forms target: patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants