refactor(compiler-cli): move downlevel decorators transform into ngtsc #44909
+956
−1,121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
added
target: patch
|
Note to reviewer: unfortunately the whitespace changes are causing too much differences for the spec file rename to be considered as rename; use git diff -M30% -w 6237234b9cf02558b12e5521633e18b62daf433c~ 6237234b9cf02558b12e5521633e18b62daf433cto see a readable diff. |
alan-agius4
approved these changes
Feb 16, 2022
dgp1130
approved these changes
Feb 23, 2022
JoostK
force-pushed
the
ngtsc/restructuring
branch
2 times, most recently
from
69017ad
to
b654f77
Compare
|
@JoostK It looks like this was approved and never merged. Is this something you still want to merge? |
|
Yes, I shall rebase! Some more approvals are needed though. |
This commit moves the `downlevel_decorators_transform` into a dedicated compilation unit within `ngtsc`. The tests were refactored to move to ngtsc's testing abstractions, allowing VE's `MockAotContext` and `MockCompilerHost` to be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This commit moves the
downlevel_decorators_transforminto a dedicatedcompilation unit within
ngtsc.The tests were refactored to move to ngtsc's testing abstractions, allowing
VE's
MockAotContextandMockCompilerHostto be removed.