Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to respect GitHub site theme #105189

Merged
merged 2 commits into from Jun 2, 2022
Merged

Update README to respect GitHub site theme #105189

merged 2 commits into from Jun 2, 2022

Conversation

cadenkriese
Copy link
Contributor

@cadenkriese cadenkriese commented Jun 2, 2022

GitHub recently added support for specifying an alternate appearance when the site is using a dark theme (see the changelog). I've implemented this here with download links from https://flutter.dev/brand.

Before:
before

After:
after

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

Requesting test exemption @Hixie

@cadenkriese
Update README to respect GitHub site theme
cc58a52 
GitHub recently added support for specifying an alternate appearance when the site is using a dark theme [(see the changelog)](https://github.blog/changelog/2022-05-19-specify-theme-context-for-images-in-markdown-beta/). I've implemented this here with download links from https://flutter.dev/brand.
Hixie
Hixie reviewed Jun 2, 2022
View changes
README.md Outdated Show resolved Hide resolved
@Hixie
Copy link
Member

@Hixie Hixie commented Jun 2, 2022

This is great!

@cadenkriese cadenkriese requested a review from Hixie Jun 2, 2022
guidezpl
guidezpl approved these changes Jun 2, 2022
View changes
Copy link
Member

@guidezpl guidezpl left a comment

Nice on the eyes

@guidezpl guidezpl merged commit 3c6719b into flutter:master Jun 2, 2022
27 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 2, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
1404f88 
…#105189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 2, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
2f67935 
…#105189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 2, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
7bf36d7 
…#105189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 2, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
5936a88 
…#105189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 2, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
f187f69 
…#105189)
@cadenkriese cadenkriese deleted the patch-1 branch Jun 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 3, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
f38c814 
…#105189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 3, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
e70d7c8 
…#105189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 3, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
9b5c355 
…#105189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Jun 3, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
69f5f3c 
…#105189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 4, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
0a6cfa5 
…#105189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 4, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
63cc6a4 
…#105189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 4, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
92fcdd2 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 5, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
3a9d8b9 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 5, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
592c16e 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 5, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
f84ff67 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 6, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
3eaa523 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 6, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
f2f3437 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 6, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
77b62f5 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 6, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
29b870e 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 6, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
7eec7c6 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 7, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
d2fba1b 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 7, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
5bcb7d8 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 7, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
1dc57cf 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 7, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
e28386f 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 7, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
d209b93 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 7, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
8b84e56 
…#105189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this issue Jun 7, 2022
@engine-flutter-autoroll
3c6719baf Update README to respect GitHub site theme (flutter/flutter…
0b7495c 
…#105189)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl

@Hixie Hixie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cadenkriese @Hixie @guidezpl