Replace rubocop with StandardRB #1415
Merged
+241
−272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the interest of making sure ViewComponent doesn't feel like it's strictly a GitHub project, this PR adopts the base configuration of `standardrb` in place of `rubocop-github`.
joelhawksley
requested review from
boardfish,
elia,
juanmanuelramallo,
Spone,
BlakeWilliams and
as code owners
|
Looking good! At first I saw Think there's more to fix on linter issues before this is green, but it's well on the way |
juanmanuelramallo
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In the interest of making sure ViewComponent doesn't feel
like it's strictly a GitHub project, this PR adopts
the base configuration of
standardrbin place ofrubocop-github.