fix(@ngtools/webpack): do not run ngcc when node_modules does not exist
#23487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
added
comp: ngtools/webpack
target: patch
|
Suggestions on how/where to add a test are welcome! |
…xist Prior to this change the CLI would fail with an error when ngcc could not be run due to a missing `node_modules` directory, as is the case with Yarn Plug'n'Play for example. The workaround was to create an empty `node_modules` directory, but this is inconvenient and shouldn't make any difference. This commit removes the error and simply skips ngcc processing.
|
I will also change this in ng-packagr once this has been reviewed/merged here. |
alan-agius4
reviewed
Jul 1, 2022
clydin
approved these changes
Jul 1, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Prior to this change the CLI would fail with an error when ngcc could not
be run due to a missing
node_modulesdirectory, as is the case with YarnPlug'n'Play for example. The workaround was to create an empty
node_modulesdirectory, but this is inconvenient and shouldn't make any difference.
This commit removes the error and simply skips ngcc processing.