Scraping prescription drug prices from Rx site using the prescription drug name and zipcode by saptarshi1996 · Pull Request #5959 · TheAlgorithms/Python

saptarshi1996 · 2022-01-30T15:10:42Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

saptarshi1996 · 2022-01-30T15:35:51Z

I have fixed all the requests. And added tests as well

saptarshi1996 · 2022-01-30T17:27:45Z

Fixed the issues and tested with black. This is my first contribution so please bear with me.

cclauss · 2022-01-30T18:31:30Z

#5960 is driving our automated testing a bit crazy.

cclauss · 2022-01-30T19:42:07Z

+        request_url: str = f'https://www.wellrx.com/prescriptions/{drug_name}/{zip_code}/?freshSearch=true'
+        response: Response = get(request_url)


Let's put type hints on function parameters and function return types but we do not need them everywhere. Both Python and mypy are capable of figuring out that a string literal is a string. ;-) Overuse slows down both the writer and reader of code.

Suggested change

request_url: str = f'https://www.wellrx.com/prescriptions/{drug_name}/{zip_code}/?freshSearch=true'

response: Response = get(request_url)

request_url = f'https://www.wellrx.com/prescriptions/{drug_name}/{zip_code}/?freshSearch=true'

response = get(request_url)

cclauss · 2022-01-30T19:44:18Z

+        response: Response = get(request_url)
+
+        # Is the status code ok?
+        if response.status_code == 200:


Let's use response.raise_for_status() instead to let the caller know what the problem is.
https://docs.python-requests.org/en/master/api/#requests.Response.raise_for_status

added response.raise_for_status() and changed the code accordingly.

cclauss · 2022-01-30T19:46:18Z

+                    # Get price of the drug.
+                    price: str = grid.find(
+                        "span", {"p", "price price-large"}).text
+                    formatted_price: float = format_price(price)


What is the reason to get rid of the $ and the two digits to the right of the decimal point? Are we going to do math (add subtract, multiply, divide) on these numbers? If not, let's not modify the formatting.

removed the conversion as we were not using those values

cclauss · 2022-01-30T19:46:56Z

+        else:
+            return None
+
+    except Exception as e:


https://realpython.com/the-most-diabolical-python-antipattern

changed except Exception as e: with except (HTTPError, exceptions.RequestException, ValueError):. This was a new learning for me.

cclauss · 2022-01-30T19:48:04Z

+    drug_name: str = input("Enter drug Name:\n")
+    zip_code: str = input("Enter zip code:\n")


See README.md for advise for leading and/or trailing spaces in input().

Went through readme and codebase and added the input as
drug_name = input("Enter drug name: ").strip()
zip_code = input("Enter zip code: ").strip()

saptarshi1996 · 2022-01-30T19:54:09Z

Thank you for the code review. These are really good points that i've missed. I'll go ahead with the requested changes.

saptarshi1996 · 2022-01-30T20:37:33Z

@cclauss Please check my commit. I've added all the requested changes.

saptarshi1996 added 2 commits January 30, 2022 19:59

add wellrx scraping

ec3fcad

write test fix docs

d01bf72

saptarshi1996 requested a review from cclauss as a code owner January 30, 2022 15:10

ghost added the require tests Tests [doctest/unittest/pytest] are required label Jan 30, 2022

ghost reviewed Jan 30, 2022

View reviewed changes

Comment thread web_programming/fetch_well_rx_price.py Outdated

Comment thread web_programming/fetch_well_rx_price.py Outdated

Comment thread web_programming/fetch_well_rx_price.py Outdated

ghost added the awaiting reviews This PR is ready to be reviewed label Jan 30, 2022

fix resolve issues

bf85317

ghost removed the require tests Tests [doctest/unittest/pytest] are required label Jan 30, 2022

ghost added the tests are failing Do not merge until tests pass label Jan 30, 2022

black format. fix returns

604e457

type check fix for union

a9dbb6a

cclauss requested changes Jan 30, 2022

View reviewed changes

ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Jan 30, 2022

black formatted

7538066

ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Jan 30, 2022

Change requests after code review

0717469

saptarshi1996 requested a review from cclauss January 30, 2022 20:40

saptarshi1996 changed the title ~~Scraping prescription drug prices from Rx site using the prescription drug name and price~~ Scraping prescription drug prices from Rx site using the prescription drug name and zipcode Jan 30, 2022

saptarshi1996 added 2 commits January 31, 2022 03:51

add precommit changes

c41a97b

flake errors

e23f308

saptarshi1996 closed this Jan 31, 2022

saptarshi1996 deleted the implement_rx_scraping_in_web_programming branch January 31, 2022 00:54

		request_url: str = f'https://www.wellrx.com/prescriptions/{drug_name}/{zip_code}/?freshSearch=true'
		response: Response = get(request_url)

		drug_name: str = input("Enter drug Name:\n")
		zip_code: str = input("Enter zip code:\n")

Uh oh!

Conversation

saptarshi1996 commented Jan 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saptarshi1996 commented Jan 30, 2022

Uh oh!

saptarshi1996 commented Jan 30, 2022

Uh oh!

cclauss commented Jan 30, 2022

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saptarshi1996 Jan 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saptarshi1996 commented Jan 30, 2022

Uh oh!

saptarshi1996 commented Jan 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

saptarshi1996 commented Jan 30, 2022 •

edited

Loading

saptarshi1996 Jan 30, 2022 •

edited

Loading