Merged
Conversation
JelleZijlstra
approved these changes
Mar 29, 2022
pablogsal
approved these changes
Mar 29, 2022
Member
|
Thanks! |
JelleZijlstra
added a commit
that referenced
this pull request
Apr 7, 2022
#2481 didn't like the hashes in the URLs
CAM-Gerlach
pushed a commit
that referenced
this pull request
Apr 16, 2022
#2481 didn't like the hashes in the URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #2479 , PEP 570 (positional-only parameters) was implemented and documented in Python 3.8 but not marked Final, likely as an oversight. This fixes that.
Fixes #2479