Skip to content

C++: Remove pragma[noinline] from ResolveGlobalVariable.ql#9735

Merged
jketema merged 1 commit intogithub:mainfrom
jketema:inline-yolo
Jul 25, 2022
Merged

C++: Remove pragma[noinline] from ResolveGlobalVariable.ql#9735
jketema merged 1 commit intogithub:mainfrom
jketema:inline-yolo

Conversation

@jketema
Copy link
Contributor

@jketema jketema commented Jun 28, 2022

No description provided.

MathiasVP
MathiasVP previously approved these changes Jun 30, 2022
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in 5e2baef LGTM! Feel free to merge that once #9700 has gone in.

@jketema jketema marked this pull request as ready for review July 22, 2022 16:04
@jketema jketema requested a review from a team as a code owner July 22, 2022 16:04
@jketema jketema added the no-change-note-required This PR does not need a change note label Jul 22, 2022
@jketema jketema marked this pull request as draft July 22, 2022 19:52
@jketema jketema marked this pull request as ready for review July 23, 2022 19:40
@geoffw0
Copy link
Contributor

geoffw0 commented Jul 25, 2022

New DCA run LGTM (there is only query flagged as slowed down, but its a very fast query and looks like wobble to me).

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving. 👍

@jketema
Copy link
Contributor Author

jketema commented Jul 25, 2022

New DCA run LGTM (there is only query flagged as slowed down, but its a very fast query and looks like wobble to me).

Yeah, I did see that exact same one wobble in a nightly last week, and also on some other of my draft PRs.

@jketema jketema merged commit 8cd0a9d into github:main Jul 25, 2022
@jketema jketema deleted the inline-yolo branch July 25, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants