Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGTM.com - false positive - unused import in try statement #9652

Open
jlaehne opened this issue Jun 22, 2022 · 1 comment
Open

LGTM.com - false positive - unused import in try statement #9652

jlaehne opened this issue Jun 22, 2022 · 1 comment
Labels
false-positive Python

Comments

@jlaehne
Copy link

@jlaehne jlaehne commented Jun 22, 2022

Description of the false positive

Unused import reported, when the import is in a try statement to check the availability of a package, which determines the tests to be run afterwards. May be good if imports in a try statement are excempt from such a report.

URL to the alert on the project page on LGTM.com

https://lgtm.com/projects/g/hyperspy/hyperspy/snapshot/508d6caf0efc5c0a258c67f5c2ecab8a977c413e/files/hyperspy/conftest.py#x4aef4cf8f643dffd:1
@jlaehne jlaehne changed the title LGTM.com - false positive LGTM.com - false positive - unused import in try statement Jun 22, 2022
@jlaehne jlaehne mentioned this issue Jun 22, 2022
Open
@tausbn
Copy link
Contributor

@tausbn tausbn commented Jun 22, 2022

Thank you for your report!

I agree that this is a false positive. We should probably ignore imports that appear inside try: ... except ImportError: ... blocks, since in that case the import statement does have an effect, even if the actual module is not used in any obvious manner.

As we're currently focusing on improving our security queries, we'll be adding this to our backlog and address it in due course.

@tausbn tausbn added the Python label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-positive Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tausbn @jlaehne