Docs: Document packaging support for CodeQL CLI 2.9.4+ on GHES 3.6+#9585
Merged
henrymercer merged 9 commits intomainfrom Jul 12, 2022
Merged
Docs: Document packaging support for CodeQL CLI 2.9.4+ on GHES 3.6+#9585henrymercer merged 9 commits intomainfrom
henrymercer merged 9 commits intomainfrom
Conversation
jf205
reviewed
Jun 20, 2022
Contributor
jf205
left a comment
jf205
left a comment
There was a problem hiding this comment.
Thanks for making this change @henrymercer. Looks like a good start to me.
henrymercer
added
the
ready-for-doc-review
aeisenberg
reviewed
Jun 28, 2022
felicitymay
previously approved these changes
Jun 29, 2022
Contributor
felicitymay
left a comment
felicitymay
left a comment
There was a problem hiding this comment.
@henrymercer - many thanks for updating the docs 🙇🏻♀️
These changes look good. I've just made a few suggestions for wording.
Following discussions on the changes to docs.github.com, we also need to update reusables/beta-note-package-management.rst to remove the reference to version 2.6.0.
Co-authored-by: Felicity Chapman <felicitymay@github.com> Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
Contributor
Done here #9753 |
aeisenberg
reviewed
Jun 30, 2022
aeisenberg
approved these changes
Jul 11, 2022
felicitymay
approved these changes
Jul 12, 2022
Contributor
felicitymay
left a comment
felicitymay
left a comment
There was a problem hiding this comment.
This LGTM ✨
Thank you for this docs update.
Contributor
Author
|
Thanks for the review all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the following docs:
to add information on managing packs on GHES 3.6+ with CodeQL CLI 2.9.4+.
We add a section on authentication too which applies to both Dotcom and GHES users.
@aeisenberg @dbartol @jf205 I'd love to get your initial thoughts on this.