gh-94315: Check for DAC override capability (GH-94316) #94316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
added
tests
``os.geteuid() == 0`` is not a reliable check whether the current user has the capability to bypass permission checks. Tests now probe for DAC override.
tiran
force-pushed
the
gh-94315-dac-check
branch
from
cb4c2e7 to
de8f91e
Compare
arhadthedev
reviewed
Jun 27, 2022
tiran
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Buildbot test failures are unrelated to the PR. |
tiran
changed the title
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 27, 2022
``os.geteuid() == 0`` is not a reliable check whether the current user has the capability to bypass permission checks. Tests now probe for DAC override. (cherry picked from commit 7e0d98e) Co-authored-by: Christian Heimes <christian@python.org>
|
GH-94346 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 27, 2022
``os.geteuid() == 0`` is not a reliable check whether the current user has the capability to bypass permission checks. Tests now probe for DAC override. (cherry picked from commit 7e0d98e) Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.geteuid() == 0is not a reliable check whether the current userhas the capability to bypass permission checks. Tests now probe for DAC
override.