Skip to content

/ python-package

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of -fPIC #114

Open
michael-o opened this issue Aug 20, 2018 · 2 comments
Open

Get rid of -fPIC #114

michael-o opened this issue Aug 20, 2018 · 2 comments

Comments

@michael-o
Copy link

@michael-o michael-o commented Aug 20, 2018

python-package/src/python/hpux_fpic.patch

Line 9 in e88eba7

+ elif host_platform.startswith('hp-ux') and 'gcc' in sysconfig.get_config_var('CC'):

I think this line is nonsense because -fPIC seems to be a compile time option. It does not make any sense to link with that. Does it?
@dumol
Copy link
Contributor

@dumol dumol commented Sep 3, 2018

I assumed it made sense upstream, where GCC is the default compiler, so our patch just makes sure this argument is not appended when using the proprietary compiler.

We don't deal with GCC issues on HP-UX on our own. If you care for that scenario, patches are welcome… ;-]
@michael-o
Copy link
Author

@michael-o michael-o commented Sep 3, 2018

Not fully, I do not consider GCC to be a default compiler on HP-UX. It is aCC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@michael-o @dumol