Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types-minimal): minimal types for only the latest Android and iOS sdks #9927

Merged
merged 3 commits into from Jun 4, 2022

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Jun 1, 2022

PR Checklist

What is the current behavior?

Currently Web-based IDEs which auto load all type declarations from anything they find in node_modules would not perform well due to high memory consumption of loading all types (even all sdks over the years).

What is the new behavior?

This package @nativescript/types-minimal optimizes to only include the latest Android and iOS sdks and allows web-based IDE's to perform extremely well.

@cla-bot cla-bot bot added the cla: yes label Jun 1, 2022
@farfromrefug
Copy link
Collaborator

@farfromrefug farfromrefug commented Jun 1, 2022

@NathanWalker love this. Could we split the androidx typing like it is done on iOS? That way there could be a way to get even faster by only using the ones you need. Could make a huge difference.
We could even think about splitting the android typings by separating android.os, android.widgets, java .....

@NathanWalker
Copy link
Contributor Author

@NathanWalker NathanWalker commented Jun 4, 2022

@NathanWalker love this. Could we split the androidx typing like it is done on iOS? That way there could be a way to get even faster by only using the ones you need. Could make a huge difference. We could even think about splitting the android typings by separating android.os, android.widgets, java .....

We can take this farther as time moves on yes. This will be step 1.

@NathanWalker NathanWalker merged commit 80e6b81 into master Jun 4, 2022
1 of 2 checks passed
@NathanWalker NathanWalker deleted the feat/types-minimal branch Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants