Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): cli.additionalPathsToClean to clean other paths with 'ns clean' #9808

Merged
merged 2 commits into from Mar 5, 2022
Merged

feat(config): cli.additionalPathsToClean to clean other paths with 'ns clean' #9808

merged 2 commits into from Mar 5, 2022

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Mar 4, 2022

PR Checklist

What is the current behavior?

What is the new behavior?

Add typing info for the existing additionalPathsToClean property that ns clean reads from.

@cla-bot cla-bot bot added the cla: yes label Mar 4, 2022
@rigor789
Copy link
Member

@rigor789 rigor789 commented Mar 4, 2022

Thanks @Archez! I do wonder if we should add this under the cli key (and update cli to match)?

@Archez
Copy link
Contributor Author

@Archez Archez commented Mar 4, 2022

@rigor789 I was thinking the same when adding it. Wasn't sure if that would be considered a breaking change, but I can make an update so the top level config isn't bloated.

@rigor789
Copy link
Member

@rigor789 rigor789 commented Mar 4, 2022

@Archez it would be fine - this was never a documented feature (I added it experimentally, but we can totally move it to the cli key)

@NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Mar 5, 2022

@rigor789 @Archez I moved it under cli key as completely agree makes sense there and super useful! Needed something like this recently. Will merge to include with 8.2 and @rigor789 we can adjust this is cli to look for it in the cli key prior to release.

@NathanWalker NathanWalker changed the base branch from master to release/8.2.0 Mar 5, 2022
@NathanWalker NathanWalker changed the title chore(typing): add clean paths typing for config feat(config): cli.additionalPathsToClean to clean other paths with 'ns clean' Mar 5, 2022
@NathanWalker NathanWalker merged commit 3ec8c42 into NativeScript:release/8.2.0 Mar 5, 2022
2 of 3 checks passed
rigor789 added a commit to NativeScript/nativescript-cli that referenced this issue Mar 5, 2022
@rigor789
fix: move additionalPathsToClean under cli object
d16a932 
ref NativeScript/NativeScript#9808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Archez @rigor789 @NathanWalker