Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): xml-namespace-loader incorrect dependency mapping #9780

Merged
merged 1 commit into from Mar 3, 2022

Conversation

rigor789
Copy link
Member

@rigor789 rigor789 commented Feb 17, 2022

PR Checklist

What is the current behavior?

In some cases xml-namespace-loader would add/register a global module without a suffix pointing to the xml file - which is incorrect because no-extension modules are reserved for code modules (ts/js). This resulted in the wrong context being passed to the custom component and failing to bind properly.

What is the new behavior?

We should now detect the "fallback" case - and not register the extensionless modules pointing to the xml files.

This partially fixes #9730 - when using a <Button> the taps are correctly handled by the parent context handler. For some reason, unrelated to this as far as I can tell, the tap event is not emitted from the <Label> inside the ActionBar.

fixes #9730

@cla-bot cla-bot bot added the cla: yes label Feb 17, 2022
@rigor789 rigor789 merged commit 151d6e8 into master Mar 3, 2022
2 of 3 checks passed
@rigor789 rigor789 deleted the fix/webpack-xml-namespace-loader-mapping branch Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant