Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack): read nativescript.config.ts main if set before package.json #9769

Merged
merged 1 commit into from Feb 18, 2022

Conversation

rigor789
Copy link
Member

@rigor789 rigor789 commented Feb 11, 2022

PR Checklist

What is the current behavior?

main in nativescript.config.ts is ignored.

What is the new behavior?

main in nativescript.config.ts is read and used instead of package.json's main when set.

implements #9658

BREAKING CHANGES:

Possibly breaking if a project has a main field set in the nativescript.config.ts - since after this lands, this value will be used instead of package.json main.

The impact is likely very small, the steps to migrate:

  1. (Option A) remove main from nativescript.config.ts if set
  2. (Option B) update main to the correct path in nativescript.config.ts if set incorrectly

@cla-bot cla-bot bot added the cla: yes label Feb 11, 2022
@rigor789 rigor789 linked an issue Feb 17, 2022 that may be closed by this pull request
3 tasks
@rigor789 rigor789 added this to the 8.2 milestone Feb 17, 2022
@rigor789 rigor789 merged commit 61ff7e4 into master Feb 18, 2022
2 of 3 checks passed
@rigor789 rigor789 deleted the feat/webpack-main-from-config branch Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants