fix(android): a11y - do not provide content description for TextView elements #9673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtView elements Android accessibility services automatically announce the text itself as the description (see https://developer.android.com/guide/topics/ui/accessibility/apps#describe-ui-element) fixes NativeScript#9588
|
One test is failing: test_automation_text_set_to_native For some reason, my change causes a new issue: My check for |
If an accessibility-property is provided, the content description should also be set for TextView elements to keep the support for Labels/Buttons that only have a font icon as text and therefore need to have an accessibilityLabel.
|
Now all tests are succeeding, at least when running them on my local machine. |
NathanWalker
changed the title
NathanWalker
merged commit 2890381
into
NativeScript:release/8.2.0
2 of 3 checks passed
NathanWalker
pushed a commit
that referenced
this issue
Feb 14, 2022
…elements (#9673) Android accessibility services automatically announce the text itself as the description (see https://developer.android.com/guide/topics/ui/accessibility/apps#describe-ui-element) If an a11y property is provided, the content description should also be set for TextView elements to keep the support for Labels/Buttons that only have a font icon as text and therefore need to have an accessibilityLabel. Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com> closes #9588
NathanWalker
pushed a commit
that referenced
this issue
Feb 15, 2022
…elements (#9673) Android accessibility services automatically announce the text itself as the description (see https://developer.android.com/guide/topics/ui/accessibility/apps#describe-ui-element) If an a11y property is provided, the content description should also be set for TextView elements to keep the support for Labels/Buttons that only have a font icon as text and therefore need to have an accessibilityLabel. Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com> closes #9588
NathanWalker
pushed a commit
that referenced
this issue
Feb 15, 2022
…elements (#9673) Android accessibility services automatically announce the text itself as the description (see https://developer.android.com/guide/topics/ui/accessibility/apps#describe-ui-element) If an a11y property is provided, the content description should also be set for TextView elements to keep the support for Labels/Buttons that only have a font icon as text and therefore need to have an accessibilityLabel. Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com> closes #9588
NathanWalker
pushed a commit
that referenced
this issue
Feb 18, 2022
…elements (#9673) Android accessibility services automatically announce the text itself as the description (see https://developer.android.com/guide/topics/ui/accessibility/apps#describe-ui-element) If an a11y property is provided, the content description should also be set for TextView elements to keep the support for Labels/Buttons that only have a font icon as text and therefore need to have an accessibilityLabel. Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com> closes #9588
NathanWalker
pushed a commit
that referenced
this issue
Mar 1, 2022
…elements (#9673) Android accessibility services automatically announce the text itself as the description (see https://developer.android.com/guide/topics/ui/accessibility/apps#describe-ui-element) If an a11y property is provided, the content description should also be set for TextView elements to keep the support for Labels/Buttons that only have a font icon as text and therefore need to have an accessibilityLabel. Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com> closes #9588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
fix(android-accessibility): do not provide content description for TextView elements
Android accessibility services automatically announce the text itself as the description (see https://developer.android.com/guide/topics/ui/accessibility/apps#describe-ui-element)
fixes #9588
PR Checklist
What is the current behavior?
Right now, content descriptions are also applied to Labels (Android TextViews) which breaks accessibility when using Labels/FormattedStrings with databinding or inside RadListViews.
The Android docs say:
What is the new behavior?
The assignment of a content description is skipped for TextView elements, now screenreaders (e.g. Google Talkback) are reading the text of a Label correctly in all situations (simple Label, FormattedString, databinding with some delay, inside RadListViews, etc...).
Fixes #9588 .