New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CSS variables should be case-sensitive. #9603

Merged

NathanWalker merged 1 commit into NativeScript:master from DimitrisRK:css-variables-fix

Oct 8, 2021

Contributor

DimitrisRK commented Oct 8, 2021 •

edited

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

CSS variables are parsed as case-insensitive.

What is the new behavior?

CSS variables will be parsed as case-sensitive.

This is the correct behaviour according to MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties#basic_usage

Note: I'm not sure what sort of test I should include for CSS variables case, so this PR contains only the fix.


          fix: CSS variables should be case-sensitive.

41d0cb3

cla-bot bot added the cla: yes label

NathanWalker approved these changes

View changes

NathanWalker added hacktoberfest hacktoberfest-accepted labels

NathanWalker merged commit 02aa0f6 into NativeScript:master

2 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment