New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): flat property using new appearance api #9558

Merged

NathanWalker merged 1 commit into NativeScript:master from jcassidyav:fix-action-bar-shadow-ios-15

Sep 20, 2021

Contributor

jcassidyav commented Sep 20, 2021

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

The flat property of the action bar is not working with NS 8.1.X on IOS.

What is the new behavior?

Set the relevant properties on the appearance to remove/hide shadow on action bar.

Fixes/Implements/Closes #9550.


          fix(ios): flat property using new appearance api

b634cc8

cla-bot bot added the cla: yes label

NathanWalker approved these changes

View changes

NathanWalker merged commit 183b4d4 into NativeScript:master

2 of 3 checks passed

NathanWalker mentioned this pull request

ActionBar flat property not working on iOS 15 #9604

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment