Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: stop adding jwt to headers #46367

Merged
merged 1 commit into from Jun 16, 2022
Merged

refactor: stop adding jwt to headers #46367

merged 1 commit into from Jun 16, 2022

Conversation

ojeytonwilliams
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams commented Jun 6, 2022 •
edited

The client never uses the header, so there's no need for the api to set
it.

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

@ojeytonwilliams
refactor: stop adding jwt to headers
7767398 
The client never uses the header, so there's no need for the api to set
it.
@ojeytonwilliams ojeytonwilliams requested a review from as a code owner Jun 6, 2022
@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Jun 6, 2022

@github-actions github-actions bot added the platform: api label Jun 6, 2022
@codesee-maps
Copy link
Contributor

@codesee-maps codesee-maps bot commented Jun 6, 2022

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@raisedadead raisedadead added the status: waiting review label Jun 7, 2022
raditotev
raditotev approved these changes Jun 13, 2022
View changes
Copy link
Contributor

@raditotev raditotev left a comment

LGTM 🚀

moT01
moT01 approved these changes Jun 16, 2022
View changes
Copy link
Member

@moT01 moT01 left a comment

LGTM 🎉

@moT01 moT01 merged commit 71b1d25 into freeCodeCamp:main Jun 16, 2022
14 checks passed
@ojeytonwilliams ojeytonwilliams deleted the refactor/remove-unused-header branch Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raditotev raditotev

@moT01 moT01

Assignees
No one assigned
Labels
platform: api status: waiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ojeytonwilliams @raditotev @moT01 @raisedadead