New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better support for mypy. #6496
Comments
|
I marked this as good first issue. Adding type checks for Python is an incremental process, parameter by parameter and function by function. It would be a good chance to review existing code base and make improvement during the process. I have made some progress on #6519 with the dask module, which is by far the most dynamic module in xgboost. Other modules can use it as a base line. Contributions are welcomed! |
|
Hi, I was wondering if I could work on this as a first issue. Thanks! |
|
@jjwang01 Please do. ;-) ping me if you need any help |
|
Is it alright if I split this into multiple PRs? |
|
@jjwang01 As many as you need. In fact, it's a good idea to have multiple PRs so we can communicate better around details. |
|
@trivialfis Is there some sort of local build script that I can use to test locally rather than after submitting a commit to PR? |
|
Hi, just wanted to follow up on this comment. |
|
Hi, sorry for missing the message.
|
Currently many more Python projects like dask and optuna are using Python type hints. With the Python package of xgboost gaining more and more features, we should also adopt mypy as a safe guard against some type errors and for better code documentation.
The text was updated successfully, but these errors were encountered: